| Summary: | Import 2dcontext Web Platform Tests | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Chris Lord <clord> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, cdumez, clord, commit-queue, eric.carlson, ews-watchlist, fred.wang, glenn, jer.noble, philipj, rniwa, rwlbuis, sergio, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf, zan | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 183720, 202455, 202457, 202458, 202459, 202460, 202516, 202517, 202518, 202523, 182686 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Dean Jackson
2017-11-02 12:30:17 PDT
Created attachment 325750 [details]
Patch
Created attachment 325764 [details]
Patch for landing
Created attachment 379893 [details]
Patch
Comment on attachment 379893 [details]
Patch
r=me if bots are happy.
If it proves difficult to have bots happy, you could try splitting the patch in 2dcontext and offlinecanvas.
I realised this patch missed setting the baseline for the offscreen-canvas tests (whoops!) - I'm just in the process of investigating the platform differences and filing the relevant bugs, it'll likely take a few more EWS submissions to get this green. Created attachment 380016 [details]
Patch
Created attachment 380024 [details]
Patch
Since this is a large patch (8 mb), svn-apply is taking very long time to apply this patch (2+ hours on some bots, e.g.: https://ews-build.webkit.org/#/builders/7/builds/10606). I cancelled the build on 'style' queue so that other patches can be processed, will retry it later when the bot is relatively free. (In reply to Aakash Jain from comment #9) > Since this is a large patch (8 mb), svn-apply is taking very long time to > apply this patch (2+ hours on some bots, e.g.: > https://ews-build.webkit.org/#/builders/7/builds/10606). > > I cancelled the build on 'style' queue so that other patches can be > processed, will retry it later when the bot is relatively free. Thanks - I think for future revisions, I'll split this patch into the offscreen-canvas tests and the 2dcontext tests - though I think the size of the latter may be the larger part of this patch... Created attachment 380094 [details]
Patch
Created attachment 380098 [details]
Patch
Created attachment 380108 [details]
Patch
I believe this latest test will be green, so I'm marking it for review/committing. I'll hold off on bug 202513 until this lands. Comment on attachment 380108 [details] Patch Clearing flags on attachment: 380108 Committed r250714: <https://trac.webkit.org/changeset/250714> All reviewed patches have been landed. Closing bug. The new test imported/w3c/web-platform-tests/2dcontext/line-styles/2d.line.cap.round.html Is failing on Mojave+ History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2F2dcontext%2Fline-styles%2F2d.line.cap.round.html Diff: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r250730%20(7141)/imported/w3c/web-platform-tests/2dcontext/line-styles/2d.line.cap.round-diff.txt |