Bug 179187

Summary:

LayoutState::m_next is really the ancestor state.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2017-11-02 11:47:45 PDT

Let's rename it.

Comment 1 Radar WebKit Bug Importer 2017-11-02 11:48:58 PDT

<rdar://problem/35319525>

Comment 2 zalan 2017-11-02 11:49:55 PDT

Created attachment 325739 [details]
Patch

Comment 3 Simon Fraser (smfr) 2017-11-02 11:51:18 PDT

Comment on attachment 325739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325739&action=review

> Source/WebCore/rendering/LayoutState.cpp:171
> +    m_lineGrid = m_ancestor->m_lineGrid;
> +    m_lineGridOffset = m_ancestor->m_lineGridOffset;
> +    m_lineGridPaginationOrigin = m_ancestor->m_lineGridPaginationOrigin;

Sucks that LayoutState knows anything about line grid.

Comment 4 WebKit Commit Bot 2017-11-02 12:24:47 PDT

Comment on attachment 325739 [details]
Patch

Clearing flags on attachment: 325739

Committed r224350: <https://trac.webkit.org/changeset/224350>

Comment 5 WebKit Commit Bot 2017-11-02 12:24:49 PDT

All reviewed patches have been landed.  Closing bug.