WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
179187
LayoutState::m_next is really the ancestor state.
https://bugs.webkit.org/show_bug.cgi?id=179187
Summary
LayoutState::m_next is really the ancestor state.
zalan
Reported
2017-11-02 11:47:45 PDT
Let's rename it.
Attachments
Patch
(7.86 KB, patch)
2017-11-02 11:49 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-11-02 11:48:58 PDT
<
rdar://problem/35319525
>
zalan
Comment 2
2017-11-02 11:49:55 PDT
Created
attachment 325739
[details]
Patch
Simon Fraser (smfr)
Comment 3
2017-11-02 11:51:18 PDT
Comment on
attachment 325739
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=325739&action=review
> Source/WebCore/rendering/LayoutState.cpp:171 > + m_lineGrid = m_ancestor->m_lineGrid; > + m_lineGridOffset = m_ancestor->m_lineGridOffset; > + m_lineGridPaginationOrigin = m_ancestor->m_lineGridPaginationOrigin;
Sucks that LayoutState knows anything about line grid.
WebKit Commit Bot
Comment 4
2017-11-02 12:24:47 PDT
Comment on
attachment 325739
[details]
Patch Clearing flags on attachment: 325739 Committed
r224350
: <
https://trac.webkit.org/changeset/224350
>
WebKit Commit Bot
Comment 5
2017-11-02 12:24:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug