Bug 179179

Summary: display:contents should work with dynamic table mutations
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, emilio, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 157477    
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2017-11-02 09:49:58 PDT
Fix some table related WPTs.
Attachments
patch (14.34 KB, patch)
2017-11-02 10:05 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-11-02 10:05:41 PDT
Created attachment 325726 [details] patch
Ryosuke Niwa
Comment 2 2017-11-02 13:58:09 PDT
Comment on attachment 325726 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=325726&action=review > Source/WebCore/style/RenderTreeUpdater.cpp:218 > -RenderTreePosition& RenderTreeUpdater::renderTreePosition() > +auto RenderTreeUpdater::renderingParent() -> Parent& I'd prefer using Parent& RenderTreeUpdater::renderingParent() instead since -> syntax doesn't seem to buy us much.
Antti Koivisto
Comment 3 2017-11-02 14:31:22 PDT
> I'd prefer using Parent& RenderTreeUpdater::renderingParent() instead since > -> syntax doesn't seem to buy us much. I have been using it in cases where it removes redundancy. This would otherwise need to be written as RenderTreeUpdater::Parent& RenderTreeUpdater::renderingParent()
Ryosuke Niwa
Comment 4 2017-11-02 14:48:09 PDT
(In reply to Antti Koivisto from comment #3) > > I'd prefer using Parent& RenderTreeUpdater::renderingParent() instead since > > -> syntax doesn't seem to buy us much. > > I have been using it in cases where it removes redundancy. This would > otherwise need to be written as > > RenderTreeUpdater::Parent& RenderTreeUpdater::renderingParent() I see. I guess it's fine but I really hate now that I have to look at left & right to see what the return type of a given function is :( We should really use one or the other throughout.
WebKit Commit Bot
Comment 5 2017-11-02 15:38:38 PDT
Comment on attachment 325726 [details] patch Clearing flags on attachment: 325726 Committed r224360: <https://trac.webkit.org/changeset/224360>
WebKit Commit Bot
Comment 6 2017-11-02 15:38:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-13 15:39:35 PST
<rdar://problem/35517797>
Note You need to log in before you can comment on or make changes to this bug.