| Summary: | display:contents should work with dynamic table mutations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, emilio, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 157477 | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2017-11-02 09:49:58 PDT
Created attachment 325726 [details]
patch
Comment on attachment 325726 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=325726&action=review > Source/WebCore/style/RenderTreeUpdater.cpp:218 > -RenderTreePosition& RenderTreeUpdater::renderTreePosition() > +auto RenderTreeUpdater::renderingParent() -> Parent& I'd prefer using Parent& RenderTreeUpdater::renderingParent() instead since -> syntax doesn't seem to buy us much. > I'd prefer using Parent& RenderTreeUpdater::renderingParent() instead since
> -> syntax doesn't seem to buy us much.
I have been using it in cases where it removes redundancy. This would otherwise need to be written as
RenderTreeUpdater::Parent& RenderTreeUpdater::renderingParent()
(In reply to Antti Koivisto from comment #3) > > I'd prefer using Parent& RenderTreeUpdater::renderingParent() instead since > > -> syntax doesn't seem to buy us much. > > I have been using it in cases where it removes redundancy. This would > otherwise need to be written as > > RenderTreeUpdater::Parent& RenderTreeUpdater::renderingParent() I see. I guess it's fine but I really hate now that I have to look at left & right to see what the return type of a given function is :( We should really use one or the other throughout. Comment on attachment 325726 [details] patch Clearing flags on attachment: 325726 Committed r224360: <https://trac.webkit.org/changeset/224360> All reviewed patches have been landed. Closing bug. |