Bug 179172

Summary: Implement FrameView::did[Start|End|Update]Scroll for subframes
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: dbates, koivisto, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179125
https://bugs.webkit.org/show_bug.cgi?id=179167
Bug Depends on:    
Bug Blocks: 149264    
Attachments:
Description Flags
Patch (not tested) none

Frédéric Wang (:fredw)
Reported 2017-11-02 08:22:32 PDT
While analyzing the difference between overflow node and subframes, I noticed that frame views don't do anything special for FrameView::didStartScroll, FrameView::didEndScroll and FrameView::didUpdateScroll, contrary to overflow layers. I am not sure whether it is actually needed for subframes? Moreoever for overflow node, it seems that it is only used when ENABLE_TOUCH_EVENTS is enabled which I can not try without the private iOS SDK (bug 179167).
Attachments
Patch (not tested) (2.40 KB, patch)
2017-11-02 08:24 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2017-11-02 08:24:16 PDT
Created attachment 325715 [details] Patch (not tested)
Frédéric Wang (:fredw)
Comment 2 2019-07-10 03:51:15 PDT
@Antti: Do you think this is actually something we need?
Simon Fraser (smfr)
Comment 3 2019-07-10 09:10:00 PDT
I don't think we need this patch.
Note You need to log in before you can comment on or make changes to this bug.