Summary: | Use more generic names than "overflow" for functions that can be used for subframes | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Component: | Frames | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, fred.wang, rbuis, simon.fraser, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=179172 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 149264 | ||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2017-11-01 10:24:15 PDT
Created attachment 325586 [details]
WIP Patch
Created attachment 325892 [details]
Patch
(In reply to Frédéric Wang (:fredw) from comment #0) > PageClient::overflowScrollViewWillStartPanGesture() > PageClient::overflowScrollViewDidScroll() > PageClient::overflowScrollWillStartScroll() > PageClient::overflowScrollDidEndScroll() I uploaded a patch for these. > > I suspect we need to implement FrameView::didStartScroll, > FrameView::didEndScroll (and FrameView::didUpdateScroll) which would > require the following functions too: > > > ChromeClient::didStartOverflowScroll() > ChromeClient::didEndOverflowScroll() Not sure whether they are needed for frame view but if that's the case, the renaming can be handled in 179172. > I'm not yet sure about EditorClient::overflowScrollPositionChange (currently > called from AsyncScrollingCoordinator::updateScrollPositionAterAsyncScroll). Still not clear what's the effect of that one and whether we need it for subframe scrolling. There is also another overflowScrollPositionChangedForNode function which is only used in WebKitLegacy. Created attachment 340075 [details]
Patch
Rebasing...
Created attachment 348914 [details]
Patch
Rebasing...
Comment on attachment 348914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348914&action=review > Source/WebKit/ChangeLog:10 > + use a more generic "scrollling node" name. "scrollling" Created attachment 349032 [details]
Patch for landing
Comment on attachment 349032 [details] Patch for landing Clearing flags on attachment: 349032 Committed r235741: <https://trac.webkit.org/changeset/235741> All reviewed patches have been landed. Closing bug. |