Bug 179110

Summary: Import MathML WPT tests
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dbarton, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/w3c/web-platform-tests/pull/8436
https://github.com/w3c/web-platform-tests/pull/8435
Bug Depends on: 179109, 180013, 174030    
Bug Blocks: 183628    
Attachments:
Description Flags
WIP Patch
none
Patch darin: review+

Frédéric Wang (:fredw)
Reported 2017-11-01 01:38:29 PDT
Created attachment 325556 [details] WIP Patch Currently the tests are in LayoutTests/imported/mathml-in-html5 but a few of them have been tweaked to make them pass in WebKit (this is bad). My main concern is the document.fonts.ready API which is used for testing many OpenType MATH fonts features but that still seems broken in WebKit (hence we have a setTimeout to delay a bit the test). For other cases not due to the the Web fonts loading issue, I think it is fine to mark them failing for now. The attached WIP patch exhibits the tweaks that were made.
Attachments
WIP Patch (700.65 KB, patch)
2017-11-01 01:38 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (956.55 KB, patch)
2017-11-25 08:53 PST, Frédéric Wang (:fredw) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2017-11-25 08:53:23 PST
Created attachment 327575 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2017-11-25 08:58:02 PST
@Youenn: Can you please review this? Note that the patch includes the following changes from web-platform-tests: https://github.com/w3c/web-platform-tests/pull/8435 https://github.com/w3c/web-platform-tests/pull/8436 I left 8 remaining tests in the legacy directory. They don't pass on WebKit without some tweaks/workaround for bug 174030 and I don't want to mark them as failing because they check important OpenType MATH parameters for MathML.
youenn fablet
Comment 3 2017-11-26 21:22:08 PST
(In reply to Frédéric Wang (:fredw) from comment #2) > @Youenn: Can you please review this? Note that the patch includes the > following changes from web-platform-tests: > > https://github.com/w3c/web-platform-tests/pull/8435 > https://github.com/w3c/web-platform-tests/pull/8436 Patches are r+ed upstream so this patch is ready to land. Maybe the importer should be stricter in the way it detects whether a file is a reference file (test_parser.py line 123).
Frédéric Wang (:fredw)
Comment 4 2017-11-27 00:53:08 PST
Committed r225162: <https://trac.webkit.org/changeset/225162>
Radar WebKit Bug Importer
Comment 5 2017-11-27 00:54:39 PST
<rdar://problem/35694026>
Note You need to log in before you can comment on or make changes to this bug.