Bug 179096

Summary:

transferFromImageBitmap should update canvas dimensions

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Canvas

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, dino, esprehn+autocc, gyuyoung.kim, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Dean Jackson 2017-10-31 17:55:19 PDT

When transferFromImageBitmap is called, the dimensions of the HTMLCanvasElement should be updated.

Comment 1 Radar WebKit Bug Importer 2017-10-31 17:55:54 PDT

<rdar://problem/35285218>

Comment 2 Dean Jackson 2017-10-31 17:59:25 PDT

Created attachment 325530 [details]
Patch

Comment 3 Sam Weinig 2017-10-31 19:06:02 PDT

Comment on attachment 325530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325530&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:982
>          m_imageBuffer = WTFMove(buffer);
>      }
>  
> +    if (m_imageBuffer && m_size != m_imageBuffer->internalSize())
> +        m_size = m_imageBuffer->internalSize();

Why is this function const?

Comment 4 Dean Jackson 2017-11-01 11:44:30 PDT

Committed r224283: <https://trac.webkit.org/changeset/224283>