| Summary: | Fix a couple of service worker tests and unskip them | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, commit-queue, ggaren, lforschler, sam, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://github.com/w3c/web-platform-tests/pull/8019#issuecomment-340915312 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2017-10-31 16:28:55 PDT
Created attachment 325521 [details]
Patch
Comment on attachment 325521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325521&action=review > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:2 > +FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller" These don't seem fixed? (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 325521 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=325521&action=review > > > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:2 > > +FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller" > > These don't seem fixed? The tests are fixed. We still do not pass them, which is expected since service workers is still being implemented. Comment on attachment 325521 [details] Patch Clearing flags on attachment: 325521 Committed r224271: <https://trac.webkit.org/changeset/224271> All reviewed patches have been landed. Closing bug. |