Bug 179088

Summary:

Fix a couple of service worker tests and unskip them

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, ggaren, lforschler, sam, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://github.com/w3c/web-platform-tests/pull/8019#issuecomment-340915312

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2017-10-31 16:28:55 PDT

Fix a couple of service worker tests and unskip them. See https://github.com/w3c/web-platform-tests/pull/8019#issuecomment-340915312

Attachments
Patch (6.93 KB, patch) 2017-10-31 16:30 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-10-31 16:30:04 PDT

Created attachment 325521 [details] Patch

Alexey Proskuryakov

Comment 2 2017-10-31 18:26:44 PDT

Comment on attachment 325521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325521&action=review > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:2 > +FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller" These don't seem fixed?

Chris Dumez

Comment 3 2017-10-31 20:08:04 PDT

(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 325521 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=325521&action=review > > > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:2 > > +FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller" > > These don't seem fixed? The tests are fixed. We still do not pass them, which is expected since service workers is still being implemented.

WebKit Commit Bot

Comment 4 2017-10-31 20:26:45 PDT

Comment on attachment 325521 [details] Patch Clearing flags on attachment: 325521 Committed r224271: <https://trac.webkit.org/changeset/224271>

WebKit Commit Bot

Comment 5 2017-10-31 20:26:47 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2017-11-15 12:29:09 PST

<rdar://problem/35567627>

Note You need to log in before you can comment on or make changes to this bug.