| Summary: | StructureStubInfo should have GPRReg members not int8_ts | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
| Status: | REOPENED --- | ||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, jlewis3, mark.lam, msaboff, sbarati | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 179083 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Keith Miller
2017-10-31 12:54:19 PDT
Created attachment 325475 [details]
Patch
Comment on attachment 325475 [details]
Patch
r=me
Created attachment 325476 [details]
Patch for landing
Comment on attachment 325475 [details]
Patch
r=me. Please also make FPRegister and SPRegister extend uint8_t for consistency. I don't mind if you do it in a separate patch.
Comment on attachment 325476 [details] Patch for landing Clearing flags on attachment: 325476 Committed r224243: <https://trac.webkit.org/changeset/224243> All reviewed patches have been landed. Closing bug. This patch caused a build failure on windows: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5699/steps/compile-webkit/logs/stdio https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5699/steps/compile-webkit/logs/stdio Re-opened since this is blocked by bug 179083 |