| Summary: | [Web Animations] Support AnimationEffect parameter in Animation constructor and read-write timeline property | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, dino, esprehn+autocc, kondapallykalyan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2017-10-31 12:15:01 PDT
Created attachment 325467 [details]
Patch
Comment on attachment 325467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325467&action=review > Source/WebCore/animation/WebAnimation.cpp:67 > +void WebAnimation::setTimeline(RefPtr<AnimationTimeline>&& timeline) I'm not sure you need && here. Why do you use it? The calling location is always casting a raw pointer to a RefPtr. I guess the implicitly created RefPtr can be moved, but I'm not sure it makes much difference. I'm clearly not a C++ expert. Comment on attachment 325467 [details] Patch Clearing flags on attachment: 325467 Committed r224242: <https://trac.webkit.org/changeset/224242> All reviewed patches have been landed. Closing bug. |