Bug 179048

Summary: Web Inspector: make ScriptCallStack::maxCallStackSizeToCapture the default value when capturing backtraces
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, dino, esprehn+autocc, graouts, gyuyoung.kim, inspector-bugzilla-changes, joepeck, kangil.han, keith_miller, kondapallykalyan, mark.lam, mkwst, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=178980
Attachments:
Description Flags
Patch none

Description Devin Rousso 2017-10-31 00:44:16 PDT
To quote JoePeck:

> We should really make ScriptCallStack::maxCallStackSizeToCapture a default value. Its ridiculous that pretty much every caller passes it.

:)
Comment 1 Devin Rousso 2017-10-31 01:55:37 PDT
Created attachment 325428 [details]
Patch
Comment 2 Mark Lam 2017-10-31 08:52:23 PDT
Comment on attachment 325428 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2017-10-31 11:04:13 PDT
Comment on attachment 325428 [details]
Patch

Nice! This is a rare case where I feel default parameter values is justified!
Comment 4 WebKit Commit Bot 2017-10-31 11:34:28 PDT
Comment on attachment 325428 [details]
Patch

Clearing flags on attachment: 325428

Committed r224236: <https://trac.webkit.org/changeset/224236>
Comment 5 WebKit Commit Bot 2017-10-31 11:34:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:35:18 PST
<rdar://problem/35567698>