Bug 179048

Summary: Web Inspector: make ScriptCallStack::maxCallStackSizeToCapture the default value when capturing backtraces
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, dino, esprehn+autocc, graouts, gyuyoung.kim, inspector-bugzilla-changes, joepeck, kangil.han, keith_miller, kondapallykalyan, mark.lam, mkwst, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=178980
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2017-10-31 00:44:16 PDT
To quote JoePeck: > We should really make ScriptCallStack::maxCallStackSizeToCapture a default value. Its ridiculous that pretty much every caller passes it. :)
Attachments
Patch (15.71 KB, patch)
2017-10-31 01:55 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-10-31 01:55:37 PDT
Created attachment 325428 [details] Patch
Mark Lam
Comment 2 2017-10-31 08:52:23 PDT
Comment on attachment 325428 [details] Patch r=me
Joseph Pecoraro
Comment 3 2017-10-31 11:04:13 PDT
Comment on attachment 325428 [details] Patch Nice! This is a rare case where I feel default parameter values is justified!
WebKit Commit Bot
Comment 4 2017-10-31 11:34:28 PDT
Comment on attachment 325428 [details] Patch Clearing flags on attachment: 325428 Committed r224236: <https://trac.webkit.org/changeset/224236>
WebKit Commit Bot
Comment 5 2017-10-31 11:34:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 12:35:18 PST
<rdar://problem/35567698>
Note You need to log in before you can comment on or make changes to this bug.