Bug 178981 – [WHLSL] Ternary expressions are unimplemented

• Component: WebGPU
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Implement ternary statements

[Robin Morisset]

Additionally, they are present in the parser, but with the ':' part missing.

[Myles C. Maxfield]

Created attachment 346953 [details]
WIP

[Myles C. Maxfield]

Created attachment 346958 [details]
Patch

[Myles C. Maxfield]

Created attachment 346960 [details]
Patch

[Saam Barati]

Comment on attachment 346960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346960&action=review

> Tools/WebGPUShadingLanguageRI/Parse.js:542
> +        consume(":");

Should we add a test for this `consume` too? I don't think you added one

[WebKit Commit Bot]

Comment on attachment 346960 [details]
Patch

Rejecting attachment 346960 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 346960, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=346960&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=178981&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 346960 from bug 178981.
Fetching: https://bugs.webkit.org/attachment.cgi?id=346960
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Saam Barati']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 14 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/WebGPUShadingLanguageRI/All.js
Hunk #1 FAILED at 149.
1 out of 1 hunk FAILED -- saving rejects to file Tools/WebGPUShadingLanguageRI/All.js.rej
patching file Tools/WebGPUShadingLanguageRI/Checker.js
Hunk #1 succeeded at 648 (offset -24 lines).
patching file Tools/WebGPUShadingLanguageRI/Evaluator.js
patching file Tools/WebGPUShadingLanguageRI/NormalUsePropertyResolver.js
patching file Tools/WebGPUShadingLanguageRI/Parse.js
Hunk #1 succeeded at 520 (offset -18 lines).
patching file Tools/WebGPUShadingLanguageRI/PropertyResolver.js
patching file Tools/WebGPUShadingLanguageRI/Rewriter.js
Hunk #1 succeeded at 164 (offset -34 lines).
patching file Tools/WebGPUShadingLanguageRI/SPIRV.html
Hunk #1 FAILED at 137.
1 out of 1 hunk FAILED -- saving rejects to file Tools/WebGPUShadingLanguageRI/SPIRV.html.rej
patching file Tools/WebGPUShadingLanguageRI/TernaryExpression.js
patching file Tools/WebGPUShadingLanguageRI/Test.html
Hunk #1 FAILED at 127.
1 out of 1 hunk FAILED -- saving rejects to file Tools/WebGPUShadingLanguageRI/Test.html.rej
patching file Tools/WebGPUShadingLanguageRI/Test.js
Hunk #1 succeeded at 198 with fuzz 1.
patching file Tools/WebGPUShadingLanguageRI/Visitor.js
Hunk #1 succeeded at 162 (offset -46 lines).
patching file Tools/WebGPUShadingLanguageRI/index.html
Hunk #1 FAILED at 127.
1 out of 1 hunk FAILED -- saving rejects to file Tools/WebGPUShadingLanguageRI/index.html.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Saam Barati']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/8963062

[Myles C. Maxfield]

Committed r235249: <https://trac.webkit.org/changeset/235249>

[Radar WebKit Bug Importer]

<rdar://problem/43659034>

[Myles C. Maxfield]

Committed r235338: <https://trac.webkit.org/changeset/235338>

[Myles C. Maxfield]

Migrated to https://github.com/gpuweb/WHLSL/issues/122