|
Description
Devin Rousso
2017-10-28 01:53:45 PDT
Created attachment 325254 [details]
Patch
Comment on attachment 325254 [details] Patch Attachment 325254 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5021753 New failing tests: inspector/canvas/recording-2d.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/recording-webgl.html inspector/canvas/create-context-webgl.html Created attachment 325255 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325254 [details] Patch Attachment 325254 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5021763 New failing tests: inspector/canvas/recording-2d.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/recording-webgl.html inspector/canvas/create-context-webgl.html Created attachment 325256 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325254 [details] Patch Attachment 325254 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5021773 New failing tests: inspector/canvas/recording-2d.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/recording-webgl.html inspector/canvas/create-context-webgl.html Created attachment 325257 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 325258 [details]
Patch
Forgot tests :P
Comment on attachment 325258 [details] Patch Attachment 325258 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5022164 New failing tests: inspector/canvas/recording-webgl-snapshots.html Created attachment 325259 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325258 [details] Patch Attachment 325258 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5022179 New failing tests: inspector/canvas/recording-webgl-snapshots.html Created attachment 325260 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325258 [details] Patch Attachment 325258 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5022189 New failing tests: inspector/canvas/recording-webgl-snapshots.html Created attachment 325261 [details]
Archive of layout-test-results from ews113 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 325271 [details]
Patch
Comment on attachment 325271 [details] Patch Attachment 325271 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5027101 New failing tests: inspector/canvas/recording-webgl-snapshots.html Created attachment 325272 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325271 [details] Patch Attachment 325271 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5027108 New failing tests: inspector/canvas/recording-webgl-snapshots.html Created attachment 325273 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325271 [details] Patch Attachment 325271 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5027119 New failing tests: inspector/canvas/recording-webgl-snapshots.html Created attachment 325274 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 325278 [details]
Patch
Comment on attachment 325278 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325278&action=review r=me > Source/WebCore/inspector/InspectorCanvas.cpp:262 > + auto stackTrace = Inspector::createScriptCallStack(JSMainThreadExecState::currentState(), Inspector::ScriptCallStack::maxCallStackSizeToCapture); We should really make ScriptCallStack::maxCallStackSizeToCapture a default value. Its ridiculous that pretty much every caller passes it. > LayoutTests/inspector/canvas/create-context-2d-expected.txt:33 > + 0: getCSSCanvasContext - [native code] Nice! See it is worth including the native function! Comment on attachment 325278 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325278&action=review >> Source/WebCore/inspector/InspectorCanvas.cpp:262 >> + auto stackTrace = Inspector::createScriptCallStack(JSMainThreadExecState::currentState(), Inspector::ScriptCallStack::maxCallStackSizeToCapture); > > We should really make ScriptCallStack::maxCallStackSizeToCapture a default value. Its ridiculous that pretty much every caller passes it. <https://webkit.org/b/179048> Web Inspector: make ScriptCallStack::maxCallStackSizeToCapture the default value when capturing backtraces Comment on attachment 325278 [details] Patch Clearing flags on attachment: 325278 Committed r224224: <https://trac.webkit.org/changeset/224224> All reviewed patches have been landed. Closing bug. |