| Summary: | Extract a WorkerDebuggerProxy interface out of WorkerReportingProxy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | WebCore Misc. | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, buildbot, cdumez, commit-queue, joepeck, sam, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 325238 [details]
[PATCH] Proposed Fix
Attachment 325238 [details] did not pass style-queue:
ERROR: Source/WebCore/workers/WorkerMessagingProxy.h:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325238 [details] [PATCH] Proposed Fix Clearing flags on attachment: 325238 Committed r224147: <https://trac.webkit.org/changeset/224147> All reviewed patches have been landed. Closing bug. |
Extract WorkerDebuggerProxy interface out of WorkerReportingProxy. This method: void postMessageToPageInspector(const String&) Is not like the others in ReportingProxy, its more like the Loader methods and can stand on its own. I'm going to extra it, with an intent to implement it soon after in ServiceWorkerThreadProxy.