Bug 178975

Summary: Extract a WorkerDebuggerProxy interface out of WorkerReportingProxy
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, buildbot, cdumez, commit-queue, joepeck, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-10-27 20:47:34 PDT
Extract WorkerDebuggerProxy interface out of WorkerReportingProxy. This method: void postMessageToPageInspector(const String&) Is not like the others in ReportingProxy, its more like the Loader methods and can stand on its own. I'm going to extra it, with an intent to implement it soon after in ServiceWorkerThreadProxy.
Attachments
[PATCH] Proposed Fix (26.97 KB, patch)
2017-10-27 21:10 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-10-27 21:10:07 PDT
Created attachment 325238 [details] [PATCH] Proposed Fix
Build Bot
Comment 2 2017-10-27 21:13:18 PDT
Attachment 325238 [details] did not pass style-queue: ERROR: Source/WebCore/workers/WorkerMessagingProxy.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-10-28 07:35:52 PDT
Comment on attachment 325238 [details] [PATCH] Proposed Fix Clearing flags on attachment: 325238 Committed r224147: <https://trac.webkit.org/changeset/224147>
WebKit Commit Bot
Comment 4 2017-10-28 07:35:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-15 12:35:15 PST
<rdar://problem/35567821>
Note You need to log in before you can comment on or make changes to this bug.