Bug 178969

Summary: Correctly determine affinity when inserting text via Keyboard Suggestions
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Description Megan Gardner 2017-10-27 19:14:58 PDT
Correctly determine affinity when inserting text via Keyboard Suggestions
Comment 1 Megan Gardner 2017-10-27 19:20:06 PDT
Created attachment 325231 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-10-27 19:21:11 PDT
<rdar://problem/35233885>
Comment 3 Ryosuke Niwa 2017-10-30 12:11:11 PDT
Comment on attachment 325231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325231&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1865
> +    // correctly determine affinity, using logic currently only present in VisiblePosition

Nit: Capitalize "correctly".
Comment 4 Megan Gardner 2017-10-30 14:25:18 PDT
https://trac.webkit.org/r224201