| Summary: | Bytecode liveness should live on UnlinkedCodeBlock so it can be shared amongst CodeBlocks | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | benjamin, buildbot, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | Safari Technology Preview | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Saam Barati
2017-10-27 12:57:42 PDT
Created attachment 325201 [details]
WIP
refactoring
Created attachment 325204 [details]
WIP
(In reply to Saam Barati from comment #2) > Created attachment 325204 [details] > WIP It seems to work. Attachment 325204 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:89: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:91: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:92: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:93: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:95: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:117: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 6 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325212 [details]
patch
Created attachment 325213 [details]
patch
Comment on attachment 325213 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=325213&action=review > Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:430 > + { > + auto locker = holdLock(m_lock); > + m_liveness = std::make_unique<BytecodeLivenessAnalysis>(codeBlock); > + } Keith pointed out I need to check if we have m_liveness already or not to avoid computing it twice. Created attachment 325214 [details]
patch
Created attachment 325219 [details]
patch
Comment on attachment 325219 [details]
patch
r=me if you get GCC working.
Comment on attachment 325219 [details] patch Clearing flags on attachment: 325219 Committed r224138: <https://trac.webkit.org/changeset/224138> All reviewed patches have been landed. Closing bug. |