Bug 178944

Summary:

Unskip more Service Workers tests

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, buildbot, commit-queue, ggaren, jlewis3, lforschler, rniwa, sam, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=174541
https://bugs.webkit.org/show_bug.cgi?id=179037

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch	ggaren: review+, commit-queue: commit-queue-
Crash Log for fetch-event	none

Chris Dumez

Reported 2017-10-27 10:29:18 PDT

Unskip more Service Workers tests.

Attachments
Patch (261.09 KB, patch) 2017-10-27 12:32 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.21 MB, application/zip) 2017-10-27 13:37 PDT, Build Bot	no flags	Details
Patch (263.03 KB, patch) 2017-10-27 13:50 PDT, Chris Dumez	ggaren: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Crash Log for fetch-event (58.52 KB, text/plain) 2017-10-30 16:27 PDT, Matt Lewis	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-10-27 12:32:15 PDT

Created attachment 325184 [details] Patch

Build Bot

Comment 2 2017-10-27 13:36:59 PDT

Comment on attachment 325184 [details] Patch Attachment 325184 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5014129 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html

Build Bot

Comment 3 2017-10-27 13:37:00 PDT

Created attachment 325192 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Chris Dumez

Comment 4 2017-10-27 13:50:09 PDT

Created attachment 325195 [details] Patch

Geoffrey Garen

Comment 5 2017-10-27 13:57:19 PDT

Comment on attachment 325195 [details] Patch r=me

WebKit Commit Bot

Comment 6 2017-10-27 14:36:40 PDT

Comment on attachment 325195 [details] Patch Rejecting attachment 325195 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 325195, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ..b1980d7 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 224129 = 8008bc5dd40f489f030622d9a96464995b169b74 r224130 = b1980d74173c702bbd3602c59b81ae63869834b7 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Total errors found: 0 in 1 files Full output: http://webkit-queues.webkit.org/results/5015058

Chris Dumez

Comment 7 2017-10-27 14:43:48 PDT

Committed r224132: <https://trac.webkit.org/changeset/224132>

Matt Lewis

Comment 8 2017-10-30 16:27:20 PDT

Created attachment 325386 [details] Crash Log for fetch-event This patch introduced a flaky crash for the test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.htmlon macOS WK2 platforms: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html first build: https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r224136%20(5579)/results.html https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/5579 The test also is a flaky failure on all platforms.

Radar WebKit Bug Importer

Comment 9 2017-11-15 12:43:15 PST

<rdar://problem/35568009>

Note You need to log in before you can comment on or make changes to this bug.