Bug 178936

Summary: [GTK][CMake] Incorrect conditional check when adding build dir to GIR runtime library path
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKitGTKAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, clopez, commit-queue, mcatanzaro, zan
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2017-10-27 06:48:08 PDT
This, in “OptionsGTK.cmake”, around line 1113: string(COMPARE EQUAL "${PREV_LOADER_LIBRARY_PATH}" "" ld_library_path_not_exist) if (ld_library_path_does_not_exist) ... Notice the different spelling of the variable used for the condition.
Attachments
Patch (1.37 KB, patch)
2017-10-27 06:52 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-10-27 06:52:07 PDT
Created attachment 325158 [details] Patch
WebKit Commit Bot
Comment 2 2017-10-27 10:33:57 PDT
Comment on attachment 325158 [details] Patch Clearing flags on attachment: 325158 Committed r224118: <https://trac.webkit.org/changeset/224118>
WebKit Commit Bot
Comment 3 2017-10-27 10:33:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.