Bug 178936

Summary:

[GTK][CMake] Incorrect conditional check when adding build dir to GIR runtime library path

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

WebKitGTK

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, cgarcia, clopez, commit-queue, mcatanzaro, zan

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adrian Perez 2017-10-27 06:48:08 PDT

This, in “OptionsGTK.cmake”, around line 1113:

    string(COMPARE EQUAL "${PREV_LOADER_LIBRARY_PATH}" "" ld_library_path_not_exist)
    if (ld_library_path_does_not_exist)
        ...

Notice the different spelling of the variable used for the condition.

Comment 1 Adrian Perez 2017-10-27 06:52:07 PDT

Created attachment 325158 [details]
Patch

Comment 2 WebKit Commit Bot 2017-10-27 10:33:57 PDT

Comment on attachment 325158 [details]
Patch

Clearing flags on attachment: 325158

Committed r224118: <https://trac.webkit.org/changeset/224118>

Comment 3 WebKit Commit Bot 2017-10-27 10:33:59 PDT

All reviewed patches have been landed.  Closing bug.