| Summary: | Plumbing for handling Service Worker scripts failing to evaluate | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, rniwa, simon.fraser, webkit-bug-importer, youennf | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Brady Eidson
2017-10-27 01:13:50 PDT
Created attachment 325136 [details]
WIP
Quick EWS run to verify no change in current tested behavior while I work on test for the new behavior
Comment on attachment 325136 [details] WIP Attachment 325136 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5010023 New failing tests: fast/workers/worker-script-error.html http/tests/workers/worker-importScriptsOnError.html Created attachment 325143 [details]
Archive of layout-test-results from ews102 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325136 [details] WIP Attachment 325136 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5010058 New failing tests: fast/workers/worker-script-error.html http/tests/workers/worker-importScriptsOnError.html Created attachment 325145 [details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325136 [details] WIP Attachment 325136 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5010121 New failing tests: fast/workers/worker-script-error.html http/tests/workers/worker-importScriptsOnError.html Created attachment 325147 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 325136 [details] WIP Attachment 325136 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5010562 New failing tests: fast/workers/worker-script-error.html http/tests/workers/worker-importScriptsOnError.html Created attachment 325148 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Subtle mistake! New patch incoming. Created attachment 325170 [details]
Another EWS run
(In reply to Brady Eidson from comment #11) > Created attachment 325170 [details] > Another EWS run Fails to apply. Might be because of me, sorry. Created attachment 325189 [details]
For EWS
Attachment 325189 [details] did not pass style-queue:
ERROR: Source/WebCore/workers/service/context/SWContextManager.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Chris Dumez from comment #12) > (In reply to Brady Eidson from comment #11) > > Created attachment 325170 [details] > > Another EWS run > > Fails to apply. Might be because of me, sorry. YUP. That's fine. Going to back burner this, because it's actually not right (We just re-read the Install algorithm and found some out of orderness) It will be needed soon, though. Rename: Handling SW scripts failing to evaluate Created attachment 325623 [details]
Patch
Comment on attachment 325623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325623&action=review r=me assuming the bots are happy. > Source/WebCore/workers/WorkerThread.cpp:190 > + if (m_hasEvaluateCallback) { This is just to avoid a dispatch? If so, I am personally not sure it is worth an extra member. We could do inside the lambda: if (evaluateCallback) evaluateCallback(message); Created attachment 325628 [details]
Patch
Comment on attachment 325628 [details] Patch Clearing flags on attachment: 325628 Committed r224295: <https://trac.webkit.org/changeset/224295> All reviewed patches have been landed. Closing bug. |