Bug 178902

Summary: Windows and WebViews are retained after re-configure
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, lforschler, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186542
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jonathan Bedard 2017-10-26 17:12:37 PDT 
Because the AutoRelease pool is declared in main, we don't release Windows and WebViews when a test changes configuration settings.  This is, in effect, a memory leak when running layout tests.

Note that this isn't the only memory leak when running WK2 layout tests.
Comment 1 Radar WebKit Bug Importer 2017-10-26 17:17:00 PDT 
<rdar://problem/35211518>
Comment 2 Radar WebKit Bug Importer 2017-10-26 17:17:01 PDT 
<rdar://problem/35211519>
Comment 3 Jonathan Bedard 2017-10-26 17:24:35 PDT 
Created attachment 325083 [details]
Patch
Comment 4 Alexey Proskuryakov 2017-10-26 17:48:57 PDT 
Comment on attachment 325083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325083&action=review

> Tools/WebKitTestRunner/TestController.cpp:1180
> +    WTF::AutodrainedPool pool;

Please remove "WTF::", AutodrainedPool is exported to the global scope (as should all public WTF symbols).
Comment 5 Jonathan Bedard 2017-10-27 07:45:05 PDT 
Created attachment 325161 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-10-27 10:21:16 PDT 
The commit-queue encountered the following flaky tests while processing attachment 325161 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-10-27 12:10:28 PDT 
Comment on attachment 325161 [details]
Patch for landing

Clearing flags on attachment: 325161

Committed r224124: <https://trac.webkit.org/changeset/224124>
Comment 8 WebKit Commit Bot 2017-10-27 12:10:29 PDT 
All reviewed patches have been landed.  Closing bug.