Bug 178902 - Windows and WebViews are retained after re-configure
Summary: Windows and WebViews are retained after re-configure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-26 17:12 PDT by Jonathan Bedard
Modified: 2018-06-29 15:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2017-10-26 17:24 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.65 KB, patch)
2017-10-27 07:45 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-10-26 17:12:37 PDT 
Because the AutoRelease pool is declared in main, we don't release Windows and WebViews when a test changes configuration settings.  This is, in effect, a memory leak when running layout tests.

Note that this isn't the only memory leak when running WK2 layout tests.
Comment 1 Radar WebKit Bug Importer 2017-10-26 17:17:00 PDT 
<rdar://problem/35211518>
Comment 2 Radar WebKit Bug Importer 2017-10-26 17:17:01 PDT 
<rdar://problem/35211519>
Comment 3 Jonathan Bedard 2017-10-26 17:24:35 PDT 
Created attachment 325083 [details]
Patch
Comment 4 Alexey Proskuryakov 2017-10-26 17:48:57 PDT 
Comment on attachment 325083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325083&action=review

> Tools/WebKitTestRunner/TestController.cpp:1180
> +    WTF::AutodrainedPool pool;

Please remove "WTF::", AutodrainedPool is exported to the global scope (as should all public WTF symbols).
Comment 5 Jonathan Bedard 2017-10-27 07:45:05 PDT 
Created attachment 325161 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-10-27 10:21:16 PDT 
The commit-queue encountered the following flaky tests while processing attachment 325161 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-10-27 12:10:28 PDT 
Comment on attachment 325161 [details]
Patch for landing

Clearing flags on attachment: 325161

Committed r224124: <https://trac.webkit.org/changeset/224124>
Comment 8 WebKit Commit Bot 2017-10-27 12:10:29 PDT 
All reviewed patches have been landed.  Closing bug.