Bug 178895

Summary:

Web Automation: denying user permission for getUserMedia doesn't work

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	none

Description BJ Burg 2017-10-26 16:46:31 PDT

The ordering of special cases is incorrect. Our hardcoded "allow mock devices and don't prompt for them" settings are short-circuiting the automation session's getUserMedia permission check.

Comment 1 BJ Burg 2017-10-26 16:46:42 PDT

rdar://problem/35210121

Comment 2 BJ Burg 2017-10-26 16:50:35 PDT

Created attachment 325079 [details]
Proposed Fix

Comment 3 youenn fablet 2017-10-26 16:53:25 PDT

LGTM.
At some point, we might want to remove mockCaptureDevicesPromptEnabled since WebDriver is a better solution.

Comment 4 WebKit Commit Bot 2017-10-26 19:32:07 PDT

Comment on attachment 325079 [details]
Proposed Fix

Clearing flags on attachment: 325079

Committed r224082: <https://trac.webkit.org/changeset/224082>

Comment 5 WebKit Commit Bot 2017-10-26 19:32:08 PDT

All reviewed patches have been landed.  Closing bug.