Bug 178895

Summary: Web Automation: denying user permission for getUserMedia doesn't work
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2017-10-26 16:46:31 PDT
The ordering of special cases is incorrect. Our hardcoded "allow mock devices and don't prompt for them" settings are short-circuiting the automation session's getUserMedia permission check.
Attachments
Proposed Fix (3.35 KB, patch)
2017-10-26 16:50 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-10-26 16:46:42 PDT
rdar://problem/35210121
Blaze Burg
Comment 2 2017-10-26 16:50:35 PDT
Created attachment 325079 [details] Proposed Fix
youenn fablet
Comment 3 2017-10-26 16:53:25 PDT
LGTM. At some point, we might want to remove mockCaptureDevicesPromptEnabled since WebDriver is a better solution.
WebKit Commit Bot
Comment 4 2017-10-26 19:32:07 PDT
Comment on attachment 325079 [details] Proposed Fix Clearing flags on attachment: 325079 Committed r224082: <https://trac.webkit.org/changeset/224082>
WebKit Commit Bot
Comment 5 2017-10-26 19:32:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.