| Summary: | Modernize AccessibilityObject.h | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | jlewis3, keith_miller, mcatanzaro, ryanhaddad, thorton, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Alex Christensen
2017-10-26 16:20:50 PDT
Created attachment 325075 [details]
Patch
Created attachment 325080 [details]
Patch
Created attachment 325081 [details]
Patch
Created attachment 325082 [details]
Patch
Created attachment 325084 [details]
Patch
Committed r224079: <https://trac.webkit.org/changeset/224079> Reopening to attach new patch. Created attachment 325098 [details]
Patch
http://trac.webkit.org/r224083 Keith attached a patch to the wrong bug :( (In reply to Alex Christensen from comment #11) > http://trac.webkit.org/r224083 > Keith attached a patch to the wrong bug :( Man, webkit-patch has not been my friend today... :( accessibility/mac/aria-label-on-label-element.html is failing after this change:
--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/accessibility/mac/aria-label-on-label-element-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/accessibility/mac/aria-label-on-label-element-actual.txt
@@ -12,7 +12,7 @@
PASS !titleUIElement1 is true
PASS input1.title is 'AXTitle: aria label'
PASS titleUIElement2.isEqual(accessibilityController.accessibleElementById('label2')) is true
-PASS input3.title is 'AXTitle: hidden aria label'
+FAIL input3.title should be AXTitle: hidden aria label. Was AXTitle: .
PASS input4.title is 'AXTitle: aria labelledby'
PASS successfullyParsed is true
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Faria-label-on-label-element.html
|