Bug 178876

Summary: Bring back SWContextManager abstraction in WebCore
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174541
Bug Depends on:    
Bug Blocks: 178794    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-10-26 10:44:21 PDT
Bring back SWContextManager abstraction in WebCore. It was killed in <https://trac.webkit.org/changeset/223718> but is actually useful when the ServiceWorker wants to message the storage process.
Attachments
Patch (60.31 KB, patch)
2017-10-26 12:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (60.35 KB, patch)
2017-10-26 12:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-10-26 12:06:40 PDT
Created attachment 325038 [details] Patch
Chris Dumez
Comment 2 2017-10-26 12:22:52 PDT
Created attachment 325040 [details] Patch
Geoffrey Garen
Comment 3 2017-10-26 12:54:19 PDT
Comment on attachment 325040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325040&action=review r=me > Source/WebCore/workers/service/context/SWContextManager.cpp:68 > + // FIXME: We should pass valid MessagePortChannels. Can you add a bug for this? > Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:99 > + // FIXME: Provide a sensical session ID. And this?
WebKit Commit Bot
Comment 4 2017-10-26 13:14:44 PDT
Comment on attachment 325040 [details] Patch Clearing flags on attachment: 325040 Committed r224041: <https://trac.webkit.org/changeset/224041>
WebKit Commit Bot
Comment 5 2017-10-26 13:14:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 12:51:57 PST
<rdar://problem/35568303>
Note You need to log in before you can comment on or make changes to this bug.