Bug 178844

Summary: WPE does not build with DragImage.cpp in unified sources.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, mcatanzaro, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2017-10-25 20:50:05 PDT
It looks like this is happening because WPE doesn't have a DragImageWPE.cpp file.
Attachments
Patch (4.62 KB, patch)
2017-10-31 18:12 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (6.52 KB, patch)
2017-11-01 10:39 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-10-31 18:12:11 PDT
Created attachment 325533 [details] Patch
Michael Catanzaro
Comment 2 2017-11-01 05:56:51 PDT
Comment on attachment 325533 [details] Patch Well I got WPE working, but looks like it broke macOS and iOS. I don't plan to debug that. :)
Keith Miller
Comment 3 2017-11-01 08:41:49 PDT
Oh, the fix for iOS/Mac is to delete the lines that say "DragImage.cpp in Sources" in WebCore.xcodeproj/proj.pbxproj
Michael Catanzaro
Comment 4 2017-11-01 10:39:45 PDT
Created attachment 325587 [details] Patch
Michael Catanzaro
Comment 5 2017-11-01 11:24:29 PDT
Looks like it works. mac-debug might be about to complain about a flaky test, though.
Keith Miller
Comment 6 2017-11-02 08:58:35 PDT
Comment on attachment 325587 [details] Patch r=me.
WebKit Commit Bot
Comment 7 2017-11-02 10:13:37 PDT
Comment on attachment 325587 [details] Patch Clearing flags on attachment: 325587 Committed r224339: <https://trac.webkit.org/changeset/224339>
WebKit Commit Bot
Comment 8 2017-11-02 10:13:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-11-17 12:37:28 PST
<rdar://problem/35621445>
Note You need to log in before you can comment on or make changes to this bug.