Bug 178843

Summary:

Remove code to update block selection

Product:

WebKit

Reporter:

Megan Gardner <megan_gardner>

Component:

New Bugs

Assignee:

Megan Gardner <megan_gardner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, enrica, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Megan Gardner 2017-10-25 20:27:55 PDT

Remove code to update block selection

Comment 1 Megan Gardner 2017-10-25 20:31:57 PDT

Created attachment 324949 [details]
Patch

Comment 2 Tim Horton 2017-10-25 20:39:20 PDT

Comment on attachment 324949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324949&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3960
> +    if ((!_selectionNeedsUpdate) || (_page->editorState().isMissingPostLayoutData))

Too many parens. Also, this should be in its own patch! Possibly with a test :)

r=me for the rest.

Comment 3 Radar WebKit Bug Importer 2017-10-25 23:04:32 PDT

<rdar://problem/35191802>

Comment 4 Megan Gardner 2017-10-26 11:20:50 PDT

https://trac.webkit.org/r224029