| Summary: | Rebase contentextensions test expectations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2017-10-25 18:16:13 PDT
Created attachment 324936 [details]
Patch
Comment on attachment 324936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324936&action=review > LayoutTests/http/tests/contentextensions/block-everything-if-domain-expected.txt:2 > +layer at (0,0) size 800x600 These changes are a bit suspicious, was there actually something known that would cause this? Comment on attachment 324936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324936&action=review >> LayoutTests/http/tests/contentextensions/block-everything-if-domain-expected.txt:2 >> +layer at (0,0) size 800x600 > > These changes are a bit suspicious, was there actually something known that would cause this? I'm not sure what would've caused this. It would've been nice to hot have these tests marked as flaky so we could've noticed that change. The important part of the test is that the console message is printed, and these results verify that that is still the case, so I think the test is still good. |