Bug 178841

Summary: Rebase contentextensions test expectations
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Alex Christensen
Reported 2017-10-25 18:16:13 PDT
Rebase contentextensions test expectations
Attachments
Patch (14.03 KB, patch)
2017-10-25 18:17 PDT, Alex Christensen 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-10-25 18:17:44 PDT
Created attachment 324936 [details] Patch
Alexey Proskuryakov
Comment 2 2017-10-25 19:10:55 PDT
Comment on attachment 324936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324936&action=review > LayoutTests/http/tests/contentextensions/block-everything-if-domain-expected.txt:2 > +layer at (0,0) size 800x600 These changes are a bit suspicious, was there actually something known that would cause this?
Alex Christensen
Comment 3 2017-10-26 11:40:14 PDT
Comment on attachment 324936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324936&action=review >> LayoutTests/http/tests/contentextensions/block-everything-if-domain-expected.txt:2 >> +layer at (0,0) size 800x600 > > These changes are a bit suspicious, was there actually something known that would cause this? I'm not sure what would've caused this. It would've been nice to hot have these tests marked as flaky so we could've noticed that change. The important part of the test is that the console message is printed, and these results verify that that is still the case, so I think the test is still good.
Alex Christensen
Comment 4 2017-10-26 11:41:55 PDT
http://trac.webkit.org/r224031
Radar WebKit Bug Importer
Comment 5 2017-11-15 12:44:39 PST
<rdar://problem/35568072>
Note You need to log in before you can comment on or make changes to this bug.