Summary: | DidMoveToNewDocumentAssertionScope shouldn't be necessary | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, kangil.han, koivisto, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2017-10-25 15:49:32 PDT
Created attachment 324918 [details]
Cleanup
Attachment 324918 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/ShadowRoot.cpp:105: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
ERROR: Source/WebCore/dom/ShadowRoot.cpp:111: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
ERROR: Source/WebCore/dom/ShadowRoot.cpp:121: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 324922 [details]
Cleanup
Comment on attachment 324922 [details]
Cleanup
r=me
Comment on attachment 324922 [details] Cleanup Clearing flags on attachment: 324922 Committed r224053: <https://trac.webkit.org/changeset/224053> All reviewed patches have been landed. Closing bug. |