Bug 178836

Summary: DidMoveToNewDocumentAssertionScope shouldn't be necessary
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, kangil.han, koivisto, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Cleanup none

Description Ryosuke Niwa 2017-10-25 15:49:32 PDT
DidMoveToNewDocumentAssertionScope is there to only ensure Node::didMoveToNewDocument
is eventually called by implementations in derived classes.

A better to way to ensure that Node::didMoveToNewDocument is always called is to simply call it directly.
Since only subclasses of Element and ShadowRoot override this virtual member function
and we already have a special case for ShadowRoot, we can de-vritualize for all non-Element cases.
Comment 1 Ryosuke Niwa 2017-10-25 15:50:19 PDT
<rdar://problem/35008876>
Comment 2 Ryosuke Niwa 2017-10-25 16:24:41 PDT
Created attachment 324918 [details]
Cleanup
Comment 3 Build Bot 2017-10-25 16:27:25 PDT
Attachment 324918 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ShadowRoot.cpp:105:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/ShadowRoot.cpp:111:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/dom/ShadowRoot.cpp:121:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ryosuke Niwa 2017-10-25 16:40:36 PDT
Created attachment 324922 [details]
Cleanup
Comment 5 Antti Koivisto 2017-10-26 00:42:01 PDT
Comment on attachment 324922 [details]
Cleanup

r=me
Comment 6 WebKit Commit Bot 2017-10-26 15:02:42 PDT
Comment on attachment 324922 [details]
Cleanup

Clearing flags on attachment: 324922

Committed r224053: <https://trac.webkit.org/changeset/224053>
Comment 7 WebKit Commit Bot 2017-10-26 15:02:43 PDT
All reviewed patches have been landed.  Closing bug.