Summary: | [Settings] Generate the bulk of WebPage::updatePreferences(...) | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, ddkilzer, dino, mcatanzaro, rniwa, thorton, webkit-bug-importer | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||
Bug Blocks: | 178637 | ||||||||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2017-10-25 12:21:57 PDT
Created attachment 324868 [details]
Patch
Created attachment 324885 [details]
Patch
Created attachment 324930 [details]
Patch
Comment on attachment 324930 [details]
Patch
ZOMG
Comment on attachment 324930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324930&action=review > Source/WebKit/Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb:2 > + * THIS FILE WAS AUTOMATICALLY GENERATED, DO NOT EDIT. Humorously not true. Comment on attachment 324930 [details] Patch Attachment 324930 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4995355 Number of test failures exceeded the failure limit. Created attachment 324973 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 325036 [details]
Patch
Comment on attachment 325036 [details] Patch Attachment 325036 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5002072 New failing tests: fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html fast/forms/interactive-validation-crash-by-style-override.html fast/forms/interactive-validation-prevented.html fast/forms/validation-messages.html fast/forms/validation-bubble-disappears-when-input-moved.html fast/forms/interactive-validation-assertion-by-validate-twice.html fast/forms/validationMessage.html fast/forms/datetimelocal/datetimelocal-interactive-validation-required.html fast/forms/time/time-interactive-validation-required.html accessibility/ios-simulator/form-control-validation-message.html fast/forms/validation-custom-message.html fast/forms/date/date-interactive-validation-required.html fast/forms/week/week-interactive-validation-required.html fast/forms/datetime/datetime-interactive-validation-required.html fast/forms/month/month-interactive-validation-required.html fast/forms/validation-bubble-disappears-when-input-detached.html fast/forms/number/number-interactive-validation-required.html fast/forms/interactive-validation-select-crash.html Created attachment 325052 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 325067 [details]
Patch
Created attachment 325073 [details]
Patch
Comment on attachment 325067 [details] Patch Attachment 325067 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5005590 New failing tests: fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html fast/forms/validation-messages.html fast/forms/validation-message-minimum-font-size.html fast/forms/validation-bubble-disappears-when-input-moved.html fast/forms/validationMessage.html fast/forms/interactive-validation-crash-by-style-override.html fast/forms/validation-bubble-disappears-when-input-detached.html fast/forms/interactive-validation-select-crash.html Created attachment 325091 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325073 [details] Patch Clearing flags on attachment: 325073 Committed r224077: <https://trac.webkit.org/changeset/224077> Awesome! It's triggered a huge warning spam with GCC, though: [830/868] Building CXX object Source/W...bKit/WebPageProxyMessageReceiver.cpp.o In file included from ../../Source/WebKit/UIProcess/WebPreferences.h:31:0, from ../../Source/WebKit/UIProcess/WebPageProxy.h:60, from DerivedSources/WebKit/WebPageProxyMessageReceiver.cpp:27: DerivedSources/WebKit/WebPreferencesDefinitions.h:256:64: warning: backslash-newline at end of file #define FOR_EACH_WEBKIT_EXPERIMENTAL_FEATURE_PREFERENCE(macro) \ The easiest way to avoid that is to leave one blink line at the bottom of the file. Follow-up incoming.... Committed r224080: <https://trac.webkit.org/changeset/224080> (Hm, this bug was not closed before I closed it... but I guess it was supposed to be. Not sure why the commit bot didn't close it.) (In reply to WebKit Commit Bot from comment #15) > Comment on attachment 325073 [details] > Patch > > Clearing flags on attachment: 325073 > > Committed r224077: <https://trac.webkit.org/changeset/224077> Build fix for internal bots: Committed r224095: <https://trac.webkit.org/changeset/224095> Thanks for all the fixes :). |