Bug 178817

Summary: PerformanceTests/TailBench9000/merge-sort.js does not actually sort any of the large arrays it allocates
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: Tools / TestsAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Robin Morisset
Reported 2017-10-25 11:16:58 PDT
More precisely, it allocates several arrays, some small, some large, some sorted, some sorted in reverse order, some random... then it only test the sort on the first of these, which is small and already sorted. I have a trivial patch for it.
Attachments
Patch (1.66 KB, patch)
2017-10-25 12:31 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.55 KB, patch)
2017-11-06 04:24 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2017-10-25 12:31:32 PDT
Created attachment 324863 [details] Patch
Saam Barati
Comment 2 2017-10-25 12:33:31 PDT
Comment on attachment 324863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324863&action=review > PerformanceTests/TailBench9000/merge-sort.js:154 > +noInline(TEST_mergeSort); Why do this? This will make the test not-runnable in browser.
Robin Morisset
Comment 3 2017-11-06 04:24:41 PST
Created attachment 326112 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-11-06 04:56:55 PST
Comment on attachment 326112 [details] Patch for landing Clearing flags on attachment: 326112 Committed r224485: <https://trac.webkit.org/changeset/224485>
WebKit Commit Bot
Comment 5 2017-11-06 04:56:56 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 12:47:44 PST
<rdar://problem/35568073>
Note You need to log in before you can comment on or make changes to this bug.