Bug 178817

Summary: PerformanceTests/TailBench9000/merge-sort.js does not actually sort any of the large arrays it allocates
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: Tools / TestsAssignee: Robin Morisset <rmorisset>
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch for landing none

Description Robin Morisset 2017-10-25 11:16:58 PDT
More precisely, it allocates several arrays, some small, some large, some sorted, some sorted in reverse order, some random... then it only test the sort on the first of these, which is small and already sorted.
I have a trivial patch for it.
Comment 1 Robin Morisset 2017-10-25 12:31:32 PDT
Created attachment 324863 [details]
Comment 2 Saam Barati 2017-10-25 12:33:31 PDT
Comment on attachment 324863 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=324863&action=review

> PerformanceTests/TailBench9000/merge-sort.js:154
> +noInline(TEST_mergeSort);

Why do this? This will make the test not-runnable in browser.
Comment 3 Robin Morisset 2017-11-06 04:24:41 PST
Created attachment 326112 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-11-06 04:56:55 PST
Comment on attachment 326112 [details]
Patch for landing

Clearing flags on attachment: 326112

Committed r224485: <https://trac.webkit.org/changeset/224485>
Comment 5 WebKit Commit Bot 2017-11-06 04:56:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:47:44 PST