Bug 178814

Summary: Web Inspector: Canvas Tab: selected canvas card loses selection outline style while recording
Product: WebKit Reporter: Brian Burg <bburg>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, drousso, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 173807, 175485    
Attachments:
Description Flags
[Image] Screenshot of issue
none
Patch
none
[Image] After Patch is applied none

Description Brian Burg 2017-10-25 10:49:50 PDT
This is awkward because I can't tell what the selection is, except by looking at the jump bar. If needed I suppose the red part could stay red, but the rest should be blue.
Comment 1 Radar WebKit Bug Importer 2017-10-25 10:50:09 PDT
<rdar://problem/35177317>
Comment 2 Devin Rousso 2017-10-25 13:02:35 PDT
Created attachment 324872 [details]
[Image] Screenshot of issue

This was done intentionally.

WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css:40
    .content-view.canvas-overview .content-view.canvas.selected:not(.is-recording) {
        border-color: var(--selected-background-color);
    }

It looks quite awful to have the red and blue right next to each other.  I agree that we still need some visual indicator, so maybe we should have the header stay red when recording and the rest of the borders be blue.
Comment 3 Devin Rousso 2017-10-25 13:12:41 PDT
Created attachment 324875 [details]
Patch
Comment 4 Devin Rousso 2017-10-25 13:13:20 PDT
Created attachment 324876 [details]
[Image] After Patch is applied
Comment 5 Brian Burg 2017-10-25 13:19:12 PDT
Comment on attachment 324875 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-10-25 14:12:03 PDT
Comment on attachment 324875 [details]
Patch

Clearing flags on attachment: 324875

Committed r223979: <https://trac.webkit.org/changeset/223979>
Comment 7 WebKit Commit Bot 2017-10-25 14:12:05 PDT
All reviewed patches have been landed.  Closing bug.