| Summary: | Web Inspector: Canvas Tab: canvas path components from old page stick around when page is reloaded | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| URL: | http://acko.net | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=178804 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 175485 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 324912 [details]
Patch
Comment on attachment 324912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324912&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + You never really explained why the code was wrong or what the fix does differently. > Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:185 > + for (let recording of canvas.recordingCollection.items) { I would comment here that we are converting the gone canvas' recordings to be imported recordings. Created attachment 325093 [details]
Patch
Added comments. No change in logic.
Comment on attachment 325093 [details] Patch Clearing flags on attachment: 325093 Committed r224081: <https://trac.webkit.org/changeset/224081> All reviewed patches have been landed. Closing bug. |
Created attachment 324841 [details] Screenshot STR: 1. Load acko.net 2. Open Inspector, Canvases Tab 3. Reload the page several times => Now I have multiple Canvas 2, Canvas 3 path components