Bug 178788

Summary: [HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 178625    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-10-25 06:17:20 PDT
Instead of using the TextRun direction. If the TextRun is ltr, but the harfbuzz buffer is rtl, the character indexes will be swapped in m_coreTextIndices.
Attachments
Patch (5.45 KB, patch)
2017-10-25 06:20 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-10-25 06:20:27 PDT
Created attachment 324814 [details] Patch
Michael Catanzaro
Comment 2 2017-10-25 08:25:19 PDT
Comment on attachment 324814 [details] Patch ¯\_(ツ)_/¯
Carlos Garcia Campos
Comment 3 2017-10-25 23:03:43 PDT
Committed r224007: <https://trac.webkit.org/changeset/224007>
Radar WebKit Bug Importer
Comment 4 2017-11-15 12:45:32 PST
<rdar://problem/35568097>
Note You need to log in before you can comment on or make changes to this bug.