Bug 178788

Summary:

[HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, mcatanzaro, mmaxfield, webkit-bug-importer

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

178625

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Carlos Garcia Campos 2017-10-25 06:17:20 PDT

Instead of using the TextRun direction. If the TextRun is ltr, but the harfbuzz buffer is rtl, the character indexes will be swapped in m_coreTextIndices.

Comment 1 Carlos Garcia Campos 2017-10-25 06:20:27 PDT

Created attachment 324814 [details]
Patch

Comment 2 Michael Catanzaro 2017-10-25 08:25:19 PDT

Comment on attachment 324814 [details]
Patch

¯\_(ツ)_/¯

Comment 3 Carlos Garcia Campos 2017-10-25 23:03:43 PDT

Committed r224007: <https://trac.webkit.org/changeset/224007>

Comment 4 Radar WebKit Bug Importer 2017-11-15 12:45:32 PST

<rdar://problem/35568097>