Bug 178788 - [HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer
Summary: [HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks: 178625
  Show dependency tree / graph
 
Reported: 2017-10-25 06:17 PDT by Carlos Garcia Campos
Modified: 2017-11-15 12:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.45 KB, patch)
2017-10-25 06:20 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-10-25 06:17:20 PDT 
Instead of using the TextRun direction. If the TextRun is ltr, but the harfbuzz buffer is rtl, the character indexes will be swapped in m_coreTextIndices.
Comment 1 Carlos Garcia Campos 2017-10-25 06:20:27 PDT 
Created attachment 324814 [details]
Patch
Comment 2 Michael Catanzaro 2017-10-25 08:25:19 PDT 
Comment on attachment 324814 [details]
Patch

¯\_(ツ)_/¯
Comment 3 Carlos Garcia Campos 2017-10-25 23:03:43 PDT 
Committed r224007: <https://trac.webkit.org/changeset/224007>
Comment 4 Radar WebKit Bug Importer 2017-11-15 12:45:32 PST 
<rdar://problem/35568097>