Bug 178774

Summary:

UNPACK_FLIP_Y is broken for MSE-backed videos

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

WebGL

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, eric.carlson, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Patch	none

Description Jer Noble 2017-10-25 00:07:39 PDT

UNPACK_FLIP_Y is broken for MSE-backed videos

Comment 1 Jer Noble 2017-10-25 00:10:19 PDT

<rdar://problem/35040012>

Comment 2 Jer Noble 2017-10-25 00:10:59 PDT

Created attachment 324801 [details]
Patch

Comment 3 Build Bot 2017-10-25 01:11:27 PDT Comment hidden (obsolete)

Comment on attachment 324801 [details]
Patch

Attachment 324801 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4981056

New failing tests:
fast/canvas/webgl/texImage2D-mse-flipY-true.html
fast/canvas/webgl/texImage2D-mse-flipY-false.html

Comment 4 Build Bot 2017-10-25 01:11:29 PDT Comment hidden (obsolete)

Created attachment 324802 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 5 Build Bot 2017-10-25 01:35:59 PDT Comment hidden (obsolete)

Comment on attachment 324801 [details]
Patch

Attachment 324801 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4981057

New failing tests:
fast/canvas/webgl/texImage2D-mse-flipY-true.html
fast/canvas/webgl/texImage2D-mse-flipY-false.html

Comment 6 Build Bot 2017-10-25 01:36:01 PDT Comment hidden (obsolete)

Created attachment 324804 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 7 Jer Noble 2017-10-25 08:34:38 PDT

Created attachment 324824 [details]
Patch

Comment 8 Dean Jackson 2017-10-25 12:05:17 PDT

Comment on attachment 324824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324824&action=review

> Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:401
> -        "       gl_Position.y = -gl_Position.y;\n"
> +        "       normalizedPosition.y = 1.0 - normalizedPosition.y;\n"

Haha. My fault for not noticing this when reviewing.

Comment 9 WebKit Commit Bot 2017-10-25 12:42:21 PDT

Comment on attachment 324824 [details]
Patch

Clearing flags on attachment: 324824

Committed r223974: <https://trac.webkit.org/changeset/223974>

Comment 10 WebKit Commit Bot 2017-10-25 12:42:22 PDT

All reviewed patches have been landed.  Closing bug.