178774 – UNPACK_FLIP_Y is broken for MSE-backed videos

Bug 178774 - UNPACK_FLIP_Y is broken for MSE-backed videos

Summary: UNPACK_FLIP_Y is broken for MSE-backed videos

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebGL (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Jer Noble

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-10-25 00:07 PDT by Jer Noble
Modified:	2017-10-25 12:42 PDT (History)
CC List:	6 users (show)

See Also:

Attachments
Patch (362.16 KB, patch) 2017-10-25 00:10 PDT, Jer Noble	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.13 MB, application/zip) 2017-10-25 01:11 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (2.14 MB, application/zip) 2017-10-25 01:36 PDT, Build Bot	no flags	Details
Patch (366.65 KB, patch) 2017-10-25 08:34 PDT, Jer Noble	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jer Noble 2017-10-25 00:07:39 PDT

UNPACK_FLIP_Y is broken for MSE-backed videos

Comment 1 Jer Noble 2017-10-25 00:10:19 PDT

<rdar://problem/35040012>

Comment 2 Jer Noble 2017-10-25 00:10:59 PDT

Created attachment 324801 [details]
Patch

Comment 3 Build Bot 2017-10-25 01:11:27 PDT Comment hidden (obsolete)

Comment on attachment 324801 [details]
Patch

Attachment 324801 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4981056

New failing tests:
fast/canvas/webgl/texImage2D-mse-flipY-true.html
fast/canvas/webgl/texImage2D-mse-flipY-false.html

Comment 4 Build Bot 2017-10-25 01:11:29 PDT Comment hidden (obsolete)

Created attachment 324802 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 5 Build Bot 2017-10-25 01:35:59 PDT Comment hidden (obsolete)

Comment on attachment 324801 [details]
Patch

Attachment 324801 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4981057

New failing tests:
fast/canvas/webgl/texImage2D-mse-flipY-true.html
fast/canvas/webgl/texImage2D-mse-flipY-false.html

Comment 6 Build Bot 2017-10-25 01:36:01 PDT Comment hidden (obsolete)

Created attachment 324804 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 7 Jer Noble 2017-10-25 08:34:38 PDT

Created attachment 324824 [details]
Patch

Comment 8 Dean Jackson 2017-10-25 12:05:17 PDT

Comment on attachment 324824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324824&action=review

> Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:401
> -        "       gl_Position.y = -gl_Position.y;\n"
> +        "       normalizedPosition.y = 1.0 - normalizedPosition.y;\n"

Haha. My fault for not noticing this when reviewing.

Comment 9 WebKit Commit Bot 2017-10-25 12:42:21 PDT

Comment on attachment 324824 [details]
Patch

Clearing flags on attachment: 324824

Committed r223974: <https://trac.webkit.org/changeset/223974>

Comment 10 WebKit Commit Bot 2017-10-25 12:42:22 PDT

All reviewed patches have been landed.  Closing bug.