Bug 178769

Summary: Add service worker handle fetch support for all subresource requests
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, buildbot, cdumez, commit-queue, dbates, japhet, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2017-10-24 18:57:53 PDT
Add service worker handle fetch support for all subresource requests
Attachments
Patch (10.10 KB, patch)
2017-10-24 19:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (10.33 KB, patch)
2017-10-26 13:14 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-10-24 19:05:01 PDT
Created attachment 324776 [details] Patch
Build Bot
Comment 2 2017-10-25 15:07:08 PDT
Attachment 324776 [details] did not pass style-queue: ERROR: Source/WebCore/loader/cache/CachedResourceRequest.h:99: The parameter name "serviceWorkerIdentifier" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-10-25 16:32:52 PDT
Comment on attachment 324776 [details] Patch Clearing flags on attachment: 324776 Committed r223994: <https://trac.webkit.org/changeset/223994>
WebKit Commit Bot
Comment 4 2017-10-25 16:32:54 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 5 2017-10-26 09:58:12 PDT
The test for this change is failing on High Sierra, Sierra, and iOS 11 WK2: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/image-fetch.https-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/image-fetch.https-actual.txt @@ -1,6 +1,6 @@ Status is no status Status is https://127.0.0.1:8443/resources/square100.png -PASS: Loaded image -Image size: 100x100 +FAIL: image loading failed +Status is https://127.0.0.1:8443/resources/square100.png https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/5282
Ryan Haddad
Comment 6 2017-10-26 10:26:26 PDT
Reverted r223994 for reason: The LayoutTest for this change is failing. Committed r224024: <https://trac.webkit.org/changeset/224024>
youenn fablet
Comment 7 2017-10-26 11:02:08 PDT
Looking at the stderr for this test, there is: NSURLSession/NSURLConnection HTTP load failed (kCFStreamErrorDomainSSL, -9814) I wonder whether that is the cause. I plan to reland the patch with test as HTTP and not HTTPS
youenn fablet
Comment 8 2017-10-26 13:14:02 PDT
Created attachment 325046 [details] Patch
Build Bot
Comment 9 2017-10-26 13:16:26 PDT
Attachment 325046 [details] did not pass style-queue: ERROR: Source/WebCore/loader/cache/CachedResourceRequest.h:99: The parameter name "serviceWorkerIdentifier" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2017-10-26 15:57:32 PDT
Comment on attachment 325046 [details] Patch Clearing flags on attachment: 325046 Committed r224059: <https://trac.webkit.org/changeset/224059>
WebKit Commit Bot
Comment 11 2017-10-26 15:57:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-11-15 12:51:00 PST
<rdar://problem/35568276>
Note You need to log in before you can comment on or make changes to this bug.