| Summary: | Add service worker handle fetch support for all subresource requests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, buildbot, cdumez, commit-queue, dbates, japhet, ryanhaddad, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2017-10-24 18:57:53 PDT
Created attachment 324776 [details]
Patch
Attachment 324776 [details] did not pass style-queue:
ERROR: Source/WebCore/loader/cache/CachedResourceRequest.h:99: The parameter name "serviceWorkerIdentifier" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 324776 [details] Patch Clearing flags on attachment: 324776 Committed r223994: <https://trac.webkit.org/changeset/223994> All reviewed patches have been landed. Closing bug. The test for this change is failing on High Sierra, Sierra, and iOS 11 WK2: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/image-fetch.https-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/image-fetch.https-actual.txt @@ -1,6 +1,6 @@ Status is no status Status is https://127.0.0.1:8443/resources/square100.png -PASS: Loaded image -Image size: 100x100 +FAIL: image loading failed +Status is https://127.0.0.1:8443/resources/square100.png https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/5282 Reverted r223994 for reason: The LayoutTest for this change is failing. Committed r224024: <https://trac.webkit.org/changeset/224024> Looking at the stderr for this test, there is: NSURLSession/NSURLConnection HTTP load failed (kCFStreamErrorDomainSSL, -9814) I wonder whether that is the cause. I plan to reland the patch with test as HTTP and not HTTPS Created attachment 325046 [details]
Patch
Attachment 325046 [details] did not pass style-queue:
ERROR: Source/WebCore/loader/cache/CachedResourceRequest.h:99: The parameter name "serviceWorkerIdentifier" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325046 [details] Patch Clearing flags on attachment: 325046 Committed r224059: <https://trac.webkit.org/changeset/224059> All reviewed patches have been landed. Closing bug. |
