Bug 178764

Summary: Make SharedStringHashTable less error prone
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-10-24 16:58:21 PDT
Make SharedStringHashTable less error prone by moving its modifying operations into a subclass.
Attachments
Patch (8.39 KB, patch)
2017-10-24 18:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.62 KB, patch)
2017-10-25 09:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.57 KB, patch)
2017-10-25 10:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-10-24 18:57:15 PDT
Created attachment 324774 [details] Patch
youenn fablet
Comment 2 2017-10-25 09:32:46 PDT
Comment on attachment 324774 [details] Patch LGTM. Usually classes are split in their own files. Maybe this should be done here as well. That way, some files would only include the ReadOnly version.
Chris Dumez
Comment 3 2017-10-25 09:49:08 PDT
Created attachment 324834 [details] Patch
Chris Dumez
Comment 4 2017-10-25 10:04:36 PDT
Created attachment 324839 [details] Patch
Chris Dumez
Comment 5 2017-10-25 10:19:47 PDT
Comment on attachment 324839 [details] Patch Clearing flags on attachment: 324839 Committed r223958: <https://trac.webkit.org/changeset/223958>
Chris Dumez
Comment 6 2017-10-25 10:19:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 12:46:35 PST
<rdar://problem/35568098>
Note You need to log in before you can comment on or make changes to this bug.