| Summary: | ServiceWorkerClientFetch should return an error that is not null in case of failure | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2017-10-24 16:26:21 PDT
Created attachment 324750 [details]
Patch
Created attachment 324756 [details]
Patch
Comment on attachment 324756 [details]
Patch
r=me
Can we add a test for this now that we have hello world? (In reply to Geoffrey Garen from comment #4) > Can we add a test for this now that we have hello world? Thanks for the review. The change is covered by basic-registration.html. The change to make use of ResourceError::Type::General makes basic-registration.html to fail. By fixing WorkerScriptLoader to not use service worker, we are back to the usual way. Comment on attachment 324756 [details] Patch Clearing flags on attachment: 324756 Committed r223944: <https://trac.webkit.org/changeset/223944> All reviewed patches have been landed. Closing bug. |