Bug 178735

Summary: Add support for unregistering a service worker
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174541
Attachments:
Description Flags
WIP Patch
none
Patch beidson: review+

Description Chris Dumez 2017-10-24 11:00:34 PDT 
Add support for unregistering a service worker:
- https://w3c.github.io/ServiceWorker/#navigator-service-worker-unregister
Comment 1 Chris Dumez 2017-10-24 12:23:37 PDT 
Created attachment 324701 [details]
WIP Patch
Comment 2 Chris Dumez 2017-10-24 13:07:06 PDT 
Created attachment 324708 [details]
Patch
Comment 3 Brady Eidson 2017-10-25 11:23:57 PDT 
Comment on attachment 324708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324708&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:181
> +    // If the origin of jobâs scope url is not jobâs client's origin, then:

Get rid of some unicode stuff (check-webkit-style used to catch these things)
Comment 4 Chris Dumez 2017-10-25 11:29:00 PDT 
Committed r223964: <https://trac.webkit.org/changeset/223964>
Comment 5 Radar WebKit Bug Importer 2017-11-15 12:49:12 PST 
<rdar://problem/35568210>