Bug 178716

Summary:

RenderThemeCocoa::mediaControlsFormattedStringForDuration may cause a crash due to unhandled Obj-C exception

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Antoine Quint 2017-10-24 00:34:04 PDT

We need to wrap calls to NSDateComponentsFormatter in a BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS block.

Comment 1 Antoine Quint 2017-10-24 00:34:17 PDT

<rdar://problem/35112900>

Comment 2 Antoine Quint 2017-10-24 00:35:31 PDT

Created attachment 324657 [details]
Patch

Comment 3 Antoine Quint 2017-10-24 09:58:16 PDT

Created attachment 324681 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2017-10-24 10:32:14 PDT

Comment on attachment 324681 [details]
Patch for landing

Clearing flags on attachment: 324681

Committed r223896: <https://trac.webkit.org/changeset/223896>

Comment 5 WebKit Commit Bot 2017-10-24 10:32:16 PDT

All reviewed patches have been landed.  Closing bug.