Summary: | -Wsubobject-linkage warning in InspectorIndexedDBAgent.cpp | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | Web Inspector | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2017-10-23 19:27:34 PDT
Created attachment 324635 [details]
Patch
Comment on attachment 324635 [details]
Patch
Interesting. Should we put this in the same anonymous namespace as the stuff at the top of the file? If this is enough though, r=me
There's only one anonymous namespace per translation unit (normally that's one file, but for us now that's a unified source bundle). So it doesn't matter where it goes. Up to you; I figured the class is in its current location for a reason. Comment on attachment 324635 [details] Patch Clearing flags on attachment: 324635 Committed r223885: <https://trac.webkit.org/changeset/223885> All reviewed patches have been landed. Closing bug. |