| Summary: | Add dom, editing, fileapi, and history to unified sources | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, ryanhaddad, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2017-10-23 17:18:41 PDT
Created attachment 324618 [details]
Patch
Attachment 324618 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 324618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324618&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). I'll remove this before landing. Comment on attachment 324618 [details]
Patch
rs=me
Committed r223865: <https://trac.webkit.org/changeset/223865> Looks like this broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5462 Yeah, I think I fixed it but it looks like https://bugs.webkit.org/show_bug.cgi?id=178690 broke the build again... :/ |