Bug 178694

Summary: Add dom, editing, fileapi, and history to unified sources
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, ryanhaddad, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Keith Miller
Reported 2017-10-23 17:18:41 PDT
Add dom, editing, fileapi, and history to unified sources
Attachments
Patch (258.25 KB, patch)
2017-10-23 17:19 PDT, Keith Miller 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-10-23 17:19:13 PDT
Created attachment 324618 [details] Patch
Build Bot
Comment 2 2017-10-23 17:20:53 PDT
Attachment 324618 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 3 2017-10-23 17:21:54 PDT
Comment on attachment 324618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324618&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). I'll remove this before landing.
Tim Horton
Comment 4 2017-10-23 17:25:30 PDT
Comment on attachment 324618 [details] Patch rs=me
Keith Miller
Comment 5 2017-10-23 17:27:47 PDT
Committed r223865: <https://trac.webkit.org/changeset/223865>
Ryan Haddad
Comment 6 2017-10-23 17:43:33 PDT
Looks like this broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5462
Keith Miller
Comment 7 2017-10-23 19:01:08 PDT
Yeah, I think I fixed it but it looks like https://bugs.webkit.org/show_bug.cgi?id=178690 broke the build again... :/
Radar WebKit Bug Importer
Comment 8 2017-11-15 12:49:28 PST
<rdar://problem/35568218>
Note You need to log in before you can comment on or make changes to this bug.