Bug 178694 - Add dom, editing, fileapi, and history to unified sources
Summary: Add dom, editing, fileapi, and history to unified sources
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
Keywords: InRadar
Depends on:
Reported: 2017-10-23 17:18 PDT by Keith Miller
Modified: 2017-11-15 12:49 PST (History)
4 users (show)

See Also:

Patch (258.25 KB, patch)
2017-10-23 17:19 PDT, Keith Miller
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-10-23 17:18:41 PDT
Add dom, editing, fileapi, and history to unified sources
Comment 1 Keith Miller 2017-10-23 17:19:13 PDT
Created attachment 324618 [details]
Comment 2 Build Bot 2017-10-23 17:20:53 PDT
Attachment 324618 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2017-10-23 17:21:54 PDT
Comment on attachment 324618 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=324618&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

I'll remove this before landing.
Comment 4 Tim Horton 2017-10-23 17:25:30 PDT
Comment on attachment 324618 [details]

Comment 5 Keith Miller 2017-10-23 17:27:47 PDT
Committed r223865: <https://trac.webkit.org/changeset/223865>
Comment 6 Ryan Haddad 2017-10-23 17:43:33 PDT
Looks like this broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5462
Comment 7 Keith Miller 2017-10-23 19:01:08 PDT
Yeah, I think I fixed it but it looks like https://bugs.webkit.org/show_bug.cgi?id=178690 broke the build again... :/
Comment 8 Radar WebKit Bug Importer 2017-11-15 12:49:28 PST