Bug 178680

Summary: Stop using _UIApplicationUsesLegacyUI()
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, simon.fraser, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2017-10-23 14:06:57 PDT
Stop using _UIApplicationUsesLegacyUI()
Attachments
Patch (3.94 KB, patch)
2017-10-23 14:09 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (3.96 KB, patch)
2017-10-23 14:22 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-10-23 14:09:08 PDT
Created attachment 324584 [details] Patch
mitz
Comment 2 2017-10-23 14:18:24 PDT
Comment on attachment 324584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324584&action=review > Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:268 > + CGFloat initialFontSize = cell.textLabel.font.pointSize; > + UIFont *font = cell.textLabel.font; Flip the order and you can just initialize initialFontSize to font.pointSize. > Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:393 > + BOOL needsNavigationController = title.length; !!title.length for targets where BOOL is a char.
Tim Horton
Comment 3 2017-10-23 14:20:35 PDT
<rdar://problem/35131949>
Tim Horton
Comment 4 2017-10-23 14:22:40 PDT
Created attachment 324587 [details] Patch
WebKit Commit Bot
Comment 5 2017-10-23 14:58:45 PDT
Comment on attachment 324587 [details] Patch Clearing flags on attachment: 324587 Committed r223857: <https://trac.webkit.org/changeset/223857>
WebKit Commit Bot
Comment 6 2017-10-23 14:58:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.