Bug 178673

Summary: Enable ServiceWorker to fetch resources
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, buildbot, cdumez, cgarcia, commit-queue, dbates, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch
none
Patch
none
Rebasing
none
Fixing didFinish/didFail
none
Patch for landing none

youenn fablet
Reported 2017-10-23 10:56:52 PDT
Currently, it posts a task to the main thread that does nothing.
Attachments
Patch (59.82 KB, patch)
2017-10-23 15:47 PDT, youenn fablet
no flags
Patch (59.84 KB, patch)
2017-10-23 16:04 PDT, youenn fablet
no flags
Patch (59.91 KB, patch)
2017-10-23 16:33 PDT, youenn fablet
no flags
Archive of layout-test-results from ews126 for ios-simulator-wk2 (969.82 KB, application/zip)
2017-10-23 17:48 PDT, Build Bot
no flags
Patch (59.97 KB, patch)
2017-10-23 19:31 PDT, youenn fablet
no flags
Patch (91.21 KB, patch)
2017-10-24 09:27 PDT, youenn fablet
no flags
Patch (91.43 KB, patch)
2017-10-24 11:38 PDT, youenn fablet
no flags
Patch (91.55 KB, patch)
2017-10-24 12:58 PDT, youenn fablet
no flags
Rebasing (86.98 KB, patch)
2017-10-24 16:42 PDT, youenn fablet
no flags
Fixing didFinish/didFail (87.65 KB, patch)
2017-10-24 16:45 PDT, youenn fablet
no flags
Patch for landing (90.03 KB, patch)
2017-10-25 12:49 PDT, youenn fablet
no flags
youenn fablet
Comment 1 2017-10-23 15:47:53 PDT
youenn fablet
Comment 2 2017-10-23 16:04:34 PDT
youenn fablet
Comment 3 2017-10-23 16:33:05 PDT
Build Bot
Comment 4 2017-10-23 17:48:56 PDT
Comment on attachment 324608 [details] Patch Attachment 324608 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4963918 New failing tests: http/tests/workers/service/service-worker-fetch.https.html
Build Bot
Comment 5 2017-10-23 17:48:57 PDT
Created attachment 324619 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
youenn fablet
Comment 6 2017-10-23 19:31:30 PDT
youenn fablet
Comment 7 2017-10-24 09:27:28 PDT
Build Bot
Comment 8 2017-10-24 09:29:26 PDT
Attachment 324678 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 9 2017-10-24 11:28:30 PDT
Comment on attachment 324678 [details] Patch Will fix GTK?WPE, Putting it r? for early feedback request
Alex Christensen
Comment 10 2017-10-24 11:33:42 PDT
Comment on attachment 324678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324678&action=review > Source/WebCore/loader/FrameLoaderClient.h:121 > + virtual uint64_t pageID() const { return 0; } > + virtual uint64_t frameID() const { return 0; } I don't think we should have a default implementation of these. This class is virtual anyways.
youenn fablet
Comment 11 2017-10-24 11:38:41 PDT
youenn fablet
Comment 12 2017-10-24 12:58:42 PDT
Build Bot
Comment 13 2017-10-24 13:01:33 PDT
Attachment 324704 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 14 2017-10-24 16:42:36 PDT
Created attachment 324752 [details] Rebasing
Build Bot
Comment 15 2017-10-24 16:43:46 PDT
Attachment 324752 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 16 2017-10-24 16:45:41 PDT
Created attachment 324754 [details] Fixing didFinish/didFail
Build Bot
Comment 17 2017-10-24 16:47:52 PDT
Attachment 324754 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 18 2017-10-24 19:15:52 PDT
This patch is moving frameID/pageID to FrameLoaderClient. A request is associated to a client which can be a document or worker scope typically. We might want to move from frameID/pageID to something like a clientID in the future. This patch also introduces ServiceWorkerProcessProxy in an attempt towards an independent ServiceWorkerProcess.
Brady Eidson
Comment 19 2017-10-25 09:57:43 PDT
Comment on attachment 324754 [details] Fixing didFinish/didFail View in context: https://bugs.webkit.org/attachment.cgi?id=324754&action=review Make Windows build. > Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.cpp:75 > + } > + PAL::SessionID sessionID() const final { return m_sessionID; } Empty line between these > Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:207 > + ASSERT_NOT_REACHED(); RELEASE_* > Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:219 > + ASSERT_NOT_REACHED(); > + return 0; > +} > + > +PAL::SessionID WebFrameLoaderClient::sessionID() const > +{ > + ASSERT_NOT_REACHED(); Ditto
youenn fablet
Comment 20 2017-10-25 12:49:00 PDT
Created attachment 324869 [details] Patch for landing
Build Bot
Comment 21 2017-10-25 12:50:13 PDT
Attachment 324869 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 22 2017-10-25 14:17:50 PDT
Comment on attachment 324869 [details] Patch for landing Clearing flags on attachment: 324869 Committed r223981: <https://trac.webkit.org/changeset/223981>
WebKit Commit Bot
Comment 23 2017-10-25 14:17:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 24 2017-11-15 13:07:47 PST
Note You need to log in before you can comment on or make changes to this bug.