| Summary: | [JSC] Drop ArityCheckData | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, darin, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2017-10-22 14:11:30 PDT
Created attachment 324532 [details]
Patch
Comment on attachment 324532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582 > + move r1, t1 nit: would be nice to add a comment # r1 contains slotsToAdd. > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517 > + move r1, t1 ditto for adding a comment about r1. Comment on attachment 324532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review Thank you for your review >> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582 >> + move r1, t1 > > nit: would be nice to add a comment # r1 contains slotsToAdd. Sounds nice, fixed. >> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517 >> + move r1, t1 > > ditto for adding a comment about r1. Ditto. Committed r223891: <https://trac.webkit.org/changeset/223891> |