Bug 178648

Summary: [JSC] Drop ArityCheckData
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, darin, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2017-10-22 14:11:30 PDT
[JSC] Drop ArityCheckData
Attachments
Patch (6.63 KB, patch)
2017-10-22 14:14 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-10-22 14:14:36 PDT
Created attachment 324532 [details] Patch
Mark Lam
Comment 2 2017-10-24 09:28:02 PDT
Comment on attachment 324532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582 > + move r1, t1 nit: would be nice to add a comment # r1 contains slotsToAdd. > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517 > + move r1, t1 ditto for adding a comment about r1.
Yusuke Suzuki
Comment 3 2017-10-24 09:35:55 PDT
Comment on attachment 324532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review Thank you for your review >> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582 >> + move r1, t1 > > nit: would be nice to add a comment # r1 contains slotsToAdd. Sounds nice, fixed. >> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517 >> + move r1, t1 > > ditto for adding a comment about r1. Ditto.
Yusuke Suzuki
Comment 4 2017-10-24 09:36:46 PDT
Committed r223891: <https://trac.webkit.org/changeset/223891>
Radar WebKit Bug Importer
Comment 5 2017-11-15 12:57:38 PST
<rdar://problem/35568480>
Note You need to log in before you can comment on or make changes to this bug.