| Summary: | [JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2017-10-22 10:49:38 PDT
Created attachment 324530 [details]
Patch
Comment on attachment 324530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review > Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976 > + linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset); Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth making a wrapper function that just passes these values so all you need to pass in is iter? Comment on attachment 324530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review >> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976 >> + linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset); > > Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth making a wrapper function that just passes these values so all you need to pass in is iter? Sounds nice! I've created `linkAllSlowCases(iter)`. I think it is very clean comparing with `linkSlowCase(iter)` function. Committed r223824: <https://trac.webkit.org/changeset/223824> |