Bug 178647

Summary: [JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2017-10-22 10:49:38 PDT
[JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling
Attachments
Patch (49.07 KB, patch)
2017-10-22 10:55 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-10-22 10:55:10 PDT
Created attachment 324530 [details] Patch
Saam Barati
Comment 2 2017-10-22 11:02:47 PDT
Comment on attachment 324530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review > Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976 > + linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset); Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth making a wrapper function that just passes these values so all you need to pass in is iter?
Yusuke Suzuki
Comment 3 2017-10-22 11:07:36 PDT
Comment on attachment 324530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review >> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976 >> + linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset); > > Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth making a wrapper function that just passes these values so all you need to pass in is iter? Sounds nice! I've created `linkAllSlowCases(iter)`. I think it is very clean comparing with `linkSlowCase(iter)` function.
Yusuke Suzuki
Comment 4 2017-10-22 11:28:33 PDT
Committed r223824: <https://trac.webkit.org/changeset/223824>
Radar WebKit Bug Importer
Comment 5 2017-11-15 12:56:52 PST
<rdar://problem/35568443>
Note You need to log in before you can comment on or make changes to this bug.