| Summary: | [JSC] Clean up baseline slow path | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2017-10-22 09:04:26 PDT
Created attachment 324528 [details]
Patch
Attachment 324528 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/jit/JIT.cpp:252: Non-label code inside switch statements should be indented. [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/JIT.cpp:261: Almost always, snprintf is better than strcat. [security/printf] [4]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 324528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324528&action=review > Source/JavaScriptCore/ChangeLog:9 > + It is good since (1) we can reduce the manual emitting code and (2) it can clearify which Typo: should be clarify Comment on attachment 324528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324528&action=review >> Source/JavaScriptCore/ChangeLog:9 >> + It is good since (1) we can reduce the manual emitting code and (2) it can clearify which > > Typo: should be clarify Thanks, fixed. Committed r223823: <https://trac.webkit.org/changeset/223823> |